h-vetinari opened a new issue, #2147: URL: https://github.com/apache/orc/issues/2147
Orc should recognize CMake / pkgconfig metadata for dependencies, ideally by default. In https://github.com/conda-forge/arrow-cpp-feedstock/pull/1697, we had to add ```batch -DLZ4_HOME="%LIBRARY_PREFIX%" ^ -DLZ4_INCLUDE_DIR="%LIBRARY_INC%" ^ -DLZ4_LIBRARY="%LIBRARY_LIB%\lz4.lib" ^ -DZSTD_HOME="%LIBRARY_PREFIX%" ^ -DZSTD_INCLUDE_DIR="%LIBRARY_INC%" ^ -DZSTD_LIBRARY="%LIBRARY_LIB%\libzstd.lib" ^ ``` otherwise orc would fail to find its dependencies. That should not be necessary, as conda-forge has complete metadata for those packages, and so orc should search _first_ try to look in `CMAKE_MODULE_PATH`, `PKG_CONFIG_PATH` (and ideally just `$PREFIX` / `CMAKE_PREFIX_PATH`) before falling back to testing `ZSTD_*` / `LZ4_*` / ... variables (and eventually failing if the dependencies really cannot be found anywhere). From my POV think this is healthy _default_ behaviour in general, but if you prefer, you can also put this behind some choice of `-DORC_PACKAGE_KIND=`. Based on the suggestion of @wgtmac, I tried this (shortly before the release of 2.1.1) in https://github.com/conda-forge/orc-feedstock/pull/86, and the existing `"conan"` / `"vcpkg"` options do not work for this purpose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
