lahwaacz commented on PR #2240: URL: https://github.com/apache/orc/pull/2240#issuecomment-2908563264
> Could you elaborate this? Try to build the latest orc version and then arrow using the following cmake options (notice especially `-DARROW_DEPENDENCY_SOURCE=SYSTEM` and `-DARROW_ORC=ON`) https://gitlab.archlinux.org/archlinux/packaging/packages/arrow/-/blob/main/PKGBUILD?ref_type=heads#L80-120 > I was thinking to remove these obsolete `FindXXX.cmake` files to use config mode of find_package so we don't have to maintain them. The "config mode" is still looking for some `.cmake` file provided by the library you are finding. Many packages do that, including protobuf, snappy, and zstd, but some don't (e.g. lz4, zlib). But cmake also has its standard `FindZLIB` module so you don't have to reimplement your own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
