WillAyd commented on code in PR #2249:
URL: https://github.com/apache/orc/pull/2249#discussion_r2124535516


##########
subprojects/orc-format.wrap:
##########


Review Comment:
   Its worth mention for those unfamiliar that the majority of the files in the 
`subprojects` directory are not written by hand, but rather created by Meson 
when running `wrap install <project_name>`
   
   This orc-format file is the singular exception, because there is no WrapDB 
entry for it (and I doubt there ever will be). By including this, Meson can 
download the source for the `orc-format` project, and the corresponding file 
`packagefiles/orc-format/meson.build` takes care of "building" the proto files 
from that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to