dongjoon-hyun commented on code in PR #2032:
URL: https://github.com/apache/orc/pull/2032#discussion_r2132971403
##########
java/core/src/java/org/apache/orc/TypeDescription.java:
##########
@@ -44,12 +44,28 @@ public class TypeDescription
public static final long MAX_DECIMAL64 = 999_999_999_999_999_999L;
public static final long MIN_DECIMAL64 = -MAX_DECIMAL64;
private static final int DEFAULT_LENGTH = 256;
+ private static final String DEFAULT_CRS = "OGC:CRS84";
static final Pattern UNQUOTED_NAMES = Pattern.compile("^[a-zA-Z0-9_]+$");
// type attributes
public static final String ENCRYPT_ATTRIBUTE = "encrypt";
public static final String MASK_ATTRIBUTE = "mask";
+ public enum EdgeInterpolationAlgorithm {
+ SPHERICAL("spherical"),
+ VINCENTY("vincenty"),
+ THOMAS("thomas"),
+ ANDOYER("andoyer"),
+ KARNEY("karney");
+
+ EdgeInterpolationAlgorithm(String name) {
+ this.name = name;
+ }
+ final String name;
+ }
Review Comment:
nit. Shall we add an empty line after this?
##########
java/core/src/java/org/apache/orc/TypeDescription.java:
##########
@@ -44,12 +44,28 @@ public class TypeDescription
public static final long MAX_DECIMAL64 = 999_999_999_999_999_999L;
public static final long MIN_DECIMAL64 = -MAX_DECIMAL64;
private static final int DEFAULT_LENGTH = 256;
+ private static final String DEFAULT_CRS = "OGC:CRS84";
static final Pattern UNQUOTED_NAMES = Pattern.compile("^[a-zA-Z0-9_]+$");
// type attributes
public static final String ENCRYPT_ATTRIBUTE = "encrypt";
public static final String MASK_ATTRIBUTE = "mask";
+ public enum EdgeInterpolationAlgorithm {
+ SPHERICAL("spherical"),
+ VINCENTY("vincenty"),
+ THOMAS("thomas"),
+ ANDOYER("andoyer"),
+ KARNEY("karney");
+
+ EdgeInterpolationAlgorithm(String name) {
+ this.name = name;
+ }
+ final String name;
+ }
+ private static final EdgeInterpolationAlgorithm
DEFAULT_EDGE_INTERPOLATION_ALGORITHM
+ =
EdgeInterpolationAlgorithm.SPHERICAL;
Review Comment:
indentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
