WillAyd commented on code in PR #2301:
URL: https://github.com/apache/orc/pull/2301#discussion_r2167016833


##########
c++/src/meson.build:
##########
@@ -173,6 +173,8 @@ source_files += files(
 
 incdir = include_directories('../include')
 orc_format_proto_dep = dependency('orc_format_proto')
+# zstd requires us to add the threads
+threads_dep = dependency('threads')

Review Comment:
   Tangentially we can look to add Meson CI for Windows. Typically the hardest 
part for Windows is getting the export macros correct, but *if* that's already 
taken care of it should be a trivial amount of effort



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to