ffacs commented on code in PR #2300:
URL: https://github.com/apache/orc/pull/2300#discussion_r2178884327
##########
java/core/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java:
##########
@@ -1676,13 +1679,15 @@ public void nextVector(ColumnVector previousVector,
public static class TimestampFromStringGroupTreeReader extends
ConvertTreeReader {
private BytesColumnVector bytesColVector;
private TimestampColumnVector timestampColVector;
+ private final boolean useUtc;
private final DateTimeFormatter formatter;
private final boolean useProlepticGregorian;
TimestampFromStringGroupTreeReader(int columnId, TypeDescription fileType,
Context context, boolean isInstant)
throws IOException {
super(columnId, getStringGroupTreeReader(columnId, fileType, context),
context);
+ useUtc = isInstant || context.getUseUTCTimestamp();
Review Comment:
No, C++ does not have the option `UseUTCTimestamp`; it uses the provided
timezone or defaults to GMT if none is specified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
