wgtmac commented on code in PR #2320:
URL: https://github.com/apache/orc/pull/2320#discussion_r2193909306
##########
java/core/src/java/org/apache/orc/geospatial/BoundingBox.java:
##########
@@ -201,7 +201,7 @@ public boolean isXYEmpty() {
* @return true if the X dimension is empty, false otherwise.
*/
public boolean isXEmpty() {
- return Double.isInfinite(xMin) && Double.isInfinite(xMax);
+ return xMin > xMax;
Review Comment:
I don't think this is correct. Empty means the bbox is still in its initial
state (a.k.a. haven't set any value). Please correct me if I was wrong.
@paleolimbot @jiayuasu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
