wgtmac commented on code in PR #2337:
URL: https://github.com/apache/orc/pull/2337#discussion_r2221723639
##########
c++/src/CMakeLists.txt:
##########
@@ -189,7 +189,8 @@ set(SOURCE_FILES
Timezone.cc
TypeImpl.cc
Vector.cc
- Writer.cc)
+ Writer.cc
+ Dictionary.cc)
Review Comment:
Please sort them alphabetically.
##########
c++/src/meson.build:
##########
@@ -170,6 +170,7 @@ source_files += files(
'TypeImpl.cc',
'Vector.cc',
'Writer.cc',
+ 'Dictionary.cc',
Review Comment:
ditto
##########
c++/src/meson.build:
##########
@@ -180,6 +181,9 @@ threads_dep = dependency('threads')
orc_lib = library(
'orc',
sources: source_files,
+ cpp_args: [
+ '-DBUILD_SPARSEHASH'
Review Comment:
@WillAyd Could you help review this? If we depend on the sparsehash library
in the meson build, what should we do on the Apache Arrow side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
