dongjoon-hyun commented on PR #28:
URL: https://github.com/apache/orc-format/pull/28#issuecomment-3184636801
I verified this PR.
**v1.0.0**
```
$ mvn compile -q
Running `/Users/dongjoon/APACHE/orc-format/mvnw`...
Using `mvn` from path: /opt/homebrew/bin/mvn
protoc-jar: executing:
[/var/folders/6y/5xv6_jg16jqgfr9qqsplfhb00000gp/T/protoc2618445239172123086.exe,
--version]
libprotoc 3.17.3
protoc-jar: executing:
[/var/folders/6y/5xv6_jg16jqgfr9qqsplfhb00000gp/T/protoc2618445239172123086.exe,
-I/Users/dongjoon/APACHE/orc-format/src/main/proto/orc/proto,
--java_out=/Users/dongjoon/APACHE/orc-format/target/generated-sources,
/Users/dongjoon/APACHE/orc-format/src/main/proto/orc/proto/orc_proto.proto]
$ grep makeExtensionsImmutable
target/generated-sources/org/apache/orc/OrcProto.java | wc -l
33
```
**v1.1.0**
```
$ mvn compile -q
Running `/Users/dongjoon/APACHE/orc-format/mvnw`...
Using `mvn` from path: /opt/homebrew/bin/mvn
protoc-jar: executing:
[/var/folders/6y/5xv6_jg16jqgfr9qqsplfhb00000gp/T/protoc12009345614848275486.exe,
--version]
libprotoc 3.17.3
protoc-jar: executing:
[/var/folders/6y/5xv6_jg16jqgfr9qqsplfhb00000gp/T/protoc12009345614848275486.exe,
-I/Users/dongjoon/APACHE/orc-format/src/main/proto/orc/proto,
--java_out=/Users/dongjoon/APACHE/orc-format/target/generated-sources,
/Users/dongjoon/APACHE/orc-format/src/main/proto/orc/proto/orc_proto.proto]
$ grep makeExtensionsImmutable
target/generated-sources/org/apache/orc/OrcProto.java | wc -l
35
```
**main branch**
```
$ mvn compile -q
Running `/Users/dongjoon/APACHE/orc-format/mvnw`...
Using `mvn` from path: /opt/homebrew/bin/mvn
protoc-jar: executing:
[/var/folders/6y/5xv6_jg16jqgfr9qqsplfhb00000gp/T/protoc14581170830221836816.exe,
--version]
libprotoc 3.17.3
protoc-jar: executing:
[/var/folders/6y/5xv6_jg16jqgfr9qqsplfhb00000gp/T/protoc14581170830221836816.exe,
-I/Users/dongjoon/APACHE/orc-format/src/main/proto/orc/proto,
--java_out=/Users/dongjoon/APACHE/orc-format/target/generated-sources,
/Users/dongjoon/APACHE/orc-format/src/main/proto/orc/proto/orc_proto.proto]
$ grep makeExtensionsImmutable
target/generated-sources/org/apache/orc/OrcProto.java | wc -l
35
```
**This PR**
```
$ mvn compile -q
Running `/Users/dongjoon/APACHE/orc-format/mvnw`...
Using `mvn` from path: /opt/homebrew/bin/mvn
protoc-jar: executing:
[/var/folders/6y/5xv6_jg16jqgfr9qqsplfhb00000gp/T/protoc12588362145100533294.exe,
--version]
libprotoc 25.8
protoc-jar: executing:
[/var/folders/6y/5xv6_jg16jqgfr9qqsplfhb00000gp/T/protoc12588362145100533294.exe,
-I/Users/dongjoon/APACHE/orc-format/src/main/proto/orc/proto,
--java_out=/Users/dongjoon/APACHE/orc-format/target/generated-sources,
/Users/dongjoon/APACHE/orc-format/src/main/proto/orc/proto/orc_proto.proto]
$ grep makeExtensionsImmutable
target/generated-sources/org/apache/orc/OrcProto.java | wc -l
0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
