luffy-zh commented on code in PR #2446:
URL: https://github.com/apache/orc/pull/2446#discussion_r2438033963
##########
c++/src/ColumnReader.cc:
##########
@@ -375,7 +376,7 @@ namespace orc {
private:
std::unique_ptr<SeekableInputStream> inputStream_;
- const uint64_t bytesPerValue_ = (columnKind == FLOAT) ? 4 : 8;
+ const int64_t bytesPerValue_ = (columnKind == DOUBLE) ? 8 : 4;
Review Comment:
Could we please replace the hard-coded values with sizeof(double) and
sizeof(float)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
