captainzmc edited a comment on pull request #1489: URL: https://github.com/apache/ozone/pull/1489#issuecomment-721492319
Thanks for @bharatviswa504's optimization Suggestions. > 3. Is there a way to disable quota feature? My question is so when upgraded during key creation we by default bytesUsed. And when not required, we don't need to update bytesUsed. (I see that we have check during checkQuota, but not during update bytesUsed) This bytesUsed should be updated all the time. If quota is not enabled when a bucket is created, then quota is enabled after a certain amount of data is written. At this point we need to know how much bytesUsed was before quota was enabled so that we can correctly update it. And in addition to quota, displaying bytesUsed on buckets also gives the user a more intuitive view of the current usage of bucket data. This is similar to bytesUsed in the current container. > 1. Can we skip updating volume bytes used during key operations, when it is required just calculated bytes used from all bucket info. As with volume lock, it affects key operations. > 2. During bucket creation why can't we make check if buckets created exceed volume quota set if so, fail bucket creation. In this way, during key operations we don't need to check volume bytesUsed, just bucket bytesUsed will be enough. Agree, I think this is a better way to avoid the current use of Volume lock. I will modify this PR in this way as soon as possible. cc @linyiqun ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
