Wei-Chiu Chuang created HDDS-4444:
-------------------------------------
Summary: Remove KeyManagerImpl#refreshPipeline because it is the
same as refresh()
Key: HDDS-4444
URL: https://issues.apache.org/jira/browse/HDDS-4444
Project: Hadoop Distributed Data Store
Issue Type: Improvement
Components: OM
Reporter: Wei-Chiu Chuang
{code:java}
/**
* Refresh pipeline info in OM by asking SCM.
* @param value OmKeyInfo
*/
@VisibleForTesting
protected void refreshPipeline(OmKeyInfo value) throws IOException {
Preconditions.checkNotNull(value, "OMKeyInfo cannot be null");
refreshPipeline(Arrays.asList(value));
} {code}
{code}
/**
* Refresh the key block location information by get latest info from SCM.
* @param key
*/
public void refresh(OmKeyInfo key) throws IOException {
Preconditions.checkNotNull(key, "Key info can not be null");
refreshPipeline(Arrays.asList(key));
}
{code}
Both methods are essentially the same. I suggeset remove refreshPipeline()
since it's protected.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
