sodonnel commented on a change in pull request #1544:
URL: https://github.com/apache/ozone/pull/1544#discussion_r521250220
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java
##########
@@ -343,6 +343,11 @@
public static final double
HDDS_DATANODE_STORAGE_UTILIZATION_CRITICAL_THRESHOLD_DEFAULT = 0.95;
+ public static final String
+ HDDS_DATANODE_METADATA_CACHE_SIZE = "hdds.datanode.metadata.cache.size";
+ public static final String
+ HDDS_DATANODE_CACHE_SIZE_DEFAULT = "64MB";
Review comment:
The usual pattern here is to have a pair of variables name like:
PARAMETER_KEY
PARAMETER_DEFAULT
I think it would be good to change this variable to
HDDS_DATANODE_METADATA_CACHE_SIZE_DEFAULT.
I see some other parameters in this file don't end in "_KEY", so I guess it
is not essential to rename HDDS_DATANODE_METADATA_CACHE_SIZE to
"HDDS_DATANODE_METADATA_CACHE_SIZE_KEY".
If we change the parameter name to
"hdds.datanode.container.rocksdb.cache.size" based on the above comment, maybe
we should also rename the variables to
HDDS_DATANODE_CONTAINER_ROCKSDB_CACHE_SIZE ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
