elek commented on a change in pull request #1551:
URL: https://github.com/apache/ozone/pull/1551#discussion_r521946625
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/SimpleContainerDownloader.java
##########
@@ -74,21 +75,13 @@ public SimpleContainerDownloader(ConfigurationSource conf,
for (DatanodeDetails datanode : sourceDatanodes) {
try {
if (result == null) {
- GrpcReplicationClient grpcReplicationClient =
- new GrpcReplicationClient(datanode.getIpAddress(),
- datanode.getPort(Name.STANDALONE).getValue(),
- workingDirectory, securityConfig, caCert);
- result = grpcReplicationClient.download(containerId);
+ result = downloadContainer(containerId, datanode);
} else {
result = result.thenApply(CompletableFuture::completedFuture)
.exceptionally(t -> {
LOG.error("Error on replicating container: " + containerId, t);
try {
- GrpcReplicationClient grpcReplicationClient =
- new GrpcReplicationClient(datanode.getIpAddress(),
- datanode.getPort(Name.STANDALONE).getValue(),
- workingDirectory, securityConfig, caCert);
- return grpcReplicationClient.download(containerId);
+ return downloadContainer(containerId, datanode);
} catch (IOException e) {
LOG.error("Error on replicating container: " + containerId,
t);
Review comment:
Nice catch, thx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
