cxorm edited a comment on pull request #1571: URL: https://github.com/apache/ozone/pull/1571#issuecomment-726183080
Thanks @ayushtkn for the contribution. IMHO the `setAcl`, `removeAcl` and `addAcl` are write-operation, the metrics should be updated in `OMRequest` instead of `OzoneManager`. (For example, when we set acl of some volume, we should update the metric in `OMVolumeSetAclRequest`) I think we could do it in a new jira. Could you be so kind as to file a jira to update it ? (Feel free to correct me if I miss something, thanks) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
