ayushtkn commented on a change in pull request #1584:
URL: https://github.com/apache/ozone/pull/1584#discussion_r523390082
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/acl/OMBucketAddAclRequest.java
##########
@@ -130,5 +131,12 @@ void onComplete(boolean operationResult, IOException
exception,
}
}
+ @Override
+ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
+ long trxnLogIndex, OzoneManagerDoubleBufferHelper omDoubleBufferHelper) {
+ ozoneManager.getMetrics().incNumAddAcl();
Review comment:
Thanx @cxorm for the review. Metrics should actually track all requests,
not just success, Secondly, in `onComplete()`, there doesn't seems to be any
instance of `ozoneManager` available, and I quickly had a check over, couple of
other files, they too were incrementing metrics in `validateAndUpdateCache`, I
think we can be in sync with them.
Let me know, if you are ok going ahead this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
