elek commented on a change in pull request #1628:
URL: https://github.com/apache/ozone/pull/1628#discussion_r539177249
##########
File path:
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneClientProducer.java
##########
@@ -130,14 +139,29 @@ private OzoneClient getClient(OzoneConfiguration config)
} catch (Throwable t) {
// For any other critical errors during object creation throw Internal
// error.
- if (LOG.isDebugEnabled()) {
- LOG.debug("Error during Client Creation: ", t);
- }
+ // if (LOG.isDebugEnabled()) {
Review comment:
Good, question. I am thinking what supposed to be the right error
handling.
AFAIK all of these exceptions are related to the user / input errors. They
are not really application errors. User errors are not required to be logged,
IMHO a permission denied is part of the normal business.
I would restore the `LOG.isDebugEnabled()` here, if you agree...
(8fe1202da)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
