avijayanhwx commented on a change in pull request #1651:
URL: https://github.com/apache/ozone/pull/1651#discussion_r539731996
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/upgrade/BasicUpgradeFinalizer.java
##########
@@ -218,14 +218,15 @@ private void persistStorage(Storage config) throws
IOException {
protected void emitNOOPMsg(String feature) {
String msg = "No finalization work defined for feature: " + feature + ".";
- String msg2 = "Skipping.";
logAndEmit(msg);
- logAndEmit(msg2);
}
protected void emitStartingMsg() {
- String msg = "Finalization started.";
+ String msg = "Finalization started.\n";
+ msg += "Existing pipelines and containers will be closed during
Upgrade.\n";
Review comment:
If we add here, then OM finalization will also print out the message.
Can we print out the message after the actual work is done (freeze pipeline
creation, pipelines are closed etc)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
