amaliujia commented on a change in pull request #1445:
URL: https://github.com/apache/ozone/pull/1445#discussion_r541302408
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
##########
@@ -885,6 +885,42 @@ public void testCheckUsedBytesQuota() throws IOException {
Assert.assertEquals(3, countException);
}
+ @Test
+ public void testVolumnUsedNamespace() throws IOException {
+ String volumeName = UUID.randomUUID().toString();
+ String bucketName = UUID.randomUUID().toString();
+ OzoneVolume volume = null;
+
+ store.createVolume(volumeName);
+ volume = store.getVolume(volumeName);
+ // The initial value should be 0
+ Assert.assertEquals(0L, volume.getUsedNamespace());
+ volume.createBucket(bucketName);
+ // Used namespace should be 1
+ volume = store.getVolume(volumeName);
+ Assert.assertEquals(1L, volume.getUsedNamespace());
+
+ // test linked bucket
+ String targetVolName = UUID.randomUUID().toString();
+ store.createVolume(targetVolName);
+ OzoneVolume volumeWithLinkedBucket = store.getVolume(targetVolName);
+ String targetBucketName = UUID.randomUUID().toString();
+ BucketArgs.Builder argsBuilder = new BucketArgs.Builder()
+ .setStorageType(StorageType.DEFAULT)
+ .setVersioning(false)
+ .setSourceVolume(volumeName)
+ .setSourceBucket(bucketName);
+ volumeWithLinkedBucket.createBucket(targetBucketName, argsBuilder.build());
+ // Used namespace should be 0 because linked bucket does not consume
+ // namespace quota
+ Assert.assertEquals(0L, volumeWithLinkedBucket.getUsedNamespace());
Review comment:
> @amaliujia , could you add a new UT for bucket link case? Linked
bucket should not be counted in the namespace quota.
This comes from one of the comment above. I consider this is more like a
decision that linked bucket should not consume quota. At least linked bucket
should not consume space quota. I think to make consistent, do not apply
namespace quota also makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
