swagle commented on a change in pull request #1494:
URL: https://github.com/apache/ozone/pull/1494#discussion_r541472568



##########
File path: 
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneHAClusterImpl.java
##########
@@ -442,7 +457,169 @@ private void initHAConfig(int basePort) throws 
IOException {
         conf.setInt(omRatisPortKey, port + 4);
       }
 
-      conf.set(omNodesKey, omNodesKeyValue.substring(1));
+      conf.set(omNodesKey, String.join(",", omNodeIds));
+    }
+  }
+
+  /**
+   * Bootstrap new OMs and add them to existing OM ring.
+   * @param numNewOMs number of new OMs to bootstrap
+   * @return list of new OMs nodeIds
+   */
+  public List<String> bootstrapOzoneManagers(int numNewOMs) throws IOException,

Review comment:
       Why is the number of newOMs an argument? I was expecting this to read 
based on the new HA configuration




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to