xiaoyuyao commented on a change in pull request #1662:
URL: https://github.com/apache/ozone/pull/1662#discussion_r543795792
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/protocol/SCMSecurityProtocol.java
##########
@@ -77,4 +80,16 @@ String getOMCertificate(OzoneManagerDetailsProto omDetails,
*/
String getCACertificate() throws IOException;
+ /**
+ * Get list of certificates meet the query criteria.
+ *
+ * @param type - node type: OM/SCM/DN.
+ * @param startSerialId - start certificate serial id.
+ * @param count - max number of certificates returned in a batch.
+ * @param isRevoked - whether list for revoked certs only.
+ * @return list of PEM encoded certificate strings.
+ */
+ List<String> listCertificate(HddsProtos.NodeType type, long startSerialId,
Review comment:
list is chosen here instead of get to be consistent with similar API/CLI
for pipeline/container/blocks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
