avijayanhwx commented on a change in pull request #1720:
URL: https://github.com/apache/ozone/pull/1720#discussion_r554726727
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/upgrade/HDDSLayoutFeatureCatalog.java
##########
@@ -39,7 +40,11 @@
private int layoutVersion;
private String description;
- private Optional< ? extends HDDSUpgradeAction> hddsUpgradeAction =
+
+ private Optional<? extends HDDSUpgradeAction> scmUpgradeAction =
+ Optional.empty();
+
+ private Optional<? extends HDDSUpgradeAction> datanodeUpgradeAction =
Review comment:
@prashantpogde I am ok with that. If we are going to add these No-Op
actions for the first upgrade release, I would suggest renaming the action to
something more intuitive rather than "DatanodeAction1" and "SCMAction1". I am
OK with doing these changes in a follow up JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
