ChenSammi commented on a change in pull request #1734:
URL: https://github.com/apache/ozone/pull/1734#discussion_r555662391
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/acl/OMBucketAddAclRequest.java
##########
@@ -116,7 +126,11 @@ OMClientResponse onFailure(OMResponse.Builder omResponse,
@Override
void onComplete(boolean operationResult, IOException exception,
- OMMetrics omMetrics) {
+ OMMetrics omMetrics, AuditLogger auditLogger,
+ Map<String, String> auditMap) {
+ auditLog(auditLogger, buildAuditMessage(OMAction.ADD_ACL, auditMap,
+ exception, getOmRequest().getUserInfo()));
Review comment:
Hi @dineshchitlangia, I have the same idea to throw the
ACLAlreadyExistsException exception when add an acl and ACL does not exist
exception when remove an acl. I plan to put the logic in ozoneAclUtil.java so
that we don't need to do the exception == null check in every ACL related
request.
And currently, there are OzoneAclUtils.java which used by bucket, key and
prefix ACL operation, and OmOzoneAclMap.java which used by volume. I'd like to
unify them and do some refactor which will be quite a big patch.
Will do it in HDDS-4650.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
