amaliujia commented on a change in pull request #1807:
URL: https://github.com/apache/ozone/pull/1807#discussion_r558623508
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -1620,18 +1620,27 @@
<property>
<name>ozone.om.ratis.minimum.timeout</name>
- <value>1s</value>
+ <value>5s</value>
<tag>OZONE, OM, RATIS, MANAGEMENT</tag>
<description>The minimum timeout duration for OM's Ratis server rpc.
</description>
</property>
+ <property>
+ <name>ozone.om.ratis.leader.step.down.wait.time</name>
+ <value>30s</value>
+ <tag>OZONE, OM, RATIS, MANAGEMENT, DEPRECATED</tag>
+ <description>The time OM Ratis Leader waits before stepping down on loosing
+ majority heartbeats from followers.
+ </description>
+ </property>
+
<property>
<name>ozone.om.leader.election.minimum.timeout.duration</name>
- <value>1s</value>
- <tag>OZONE, OM, RATIS, MANAGEMENT</tag>
- <description>The minimum timeout duration for OM ratis leader election.
- Default is 1s.
+ <value>5s</value>
+ <tag>OZONE, OM, RATIS, MANAGEMENT, DEPRECATED</tag>
+ <description>DEPRECATED. Leader election timeout uses ratis
+ rpc timeout which can be set via ozone.om.ratis.minimum.timeout.
Review comment:
OUt of curiosity:
so the deprecation of a config entry is to put `DEPRECATED` in the
description?
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -1620,18 +1620,27 @@
<property>
<name>ozone.om.ratis.minimum.timeout</name>
- <value>1s</value>
+ <value>5s</value>
<tag>OZONE, OM, RATIS, MANAGEMENT</tag>
<description>The minimum timeout duration for OM's Ratis server rpc.
</description>
</property>
+ <property>
+ <name>ozone.om.ratis.leader.step.down.wait.time</name>
+ <value>30s</value>
+ <tag>OZONE, OM, RATIS, MANAGEMENT, DEPRECATED</tag>
+ <description>The time OM Ratis Leader waits before stepping down on loosing
+ majority heartbeats from followers.
+ </description>
+ </property>
+
<property>
<name>ozone.om.leader.election.minimum.timeout.duration</name>
- <value>1s</value>
- <tag>OZONE, OM, RATIS, MANAGEMENT</tag>
- <description>The minimum timeout duration for OM ratis leader election.
- Default is 1s.
+ <value>5s</value>
+ <tag>OZONE, OM, RATIS, MANAGEMENT, DEPRECATED</tag>
+ <description>DEPRECATED. Leader election timeout uses ratis
+ rpc timeout which can be set via ozone.om.ratis.minimum.timeout.
Review comment:
Out of curiosity:
so the deprecation of a config entry is to put `DEPRECATED` in the
description?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
