bshashikant commented on pull request #1828: URL: https://github.com/apache/ozone/pull/1828#issuecomment-764531275
> @GlenGeng @amaliujia @runzhiwang Thanks for reviewing the PR! > > > For the txnId, since SCM HA will keep the DeletedBlocksTXTable to be the same across SCMs, I consider we don't need the distributed sequence id solution any more, this solution will be sufficient. > > I agree with @GlenGeng . Since delete blocks table would be consistent across all SCM instances, we might not need DistributedSequenceIdGenerator for delete transactionId. I agree with @lokeshj1703 and @GlenGeng here. This seems to be better approach to handle delete transactionId for both ratis and non-ratis case. I would prefer to get this patch committed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
