elek commented on a change in pull request #1776:
URL: https://github.com/apache/ozone/pull/1776#discussion_r564523403
##########
File path:
hadoop-ozone/ozonefs-hadoop2/src/main/java/org/apache/hadoop/fs/ozone/Hadoop27RpcTransport.java
##########
@@ -67,6 +69,12 @@ public OMResponse submitRequest(OMRequest payload) throws
IOException {
try {
return proxy.submitRequest(NULL_RPC_CONTROLLER, payload);
} catch (ServiceException e) {
+ OMNotLeaderException notLeaderException =
Review comment:
> And if the client is on the leader server, the proxy would be
successfully created and no exceptions should be thrown
Thanks the clarification (and sorry for the late answer).
Based on my understanding this code throws exception only if the client is
connected to a follower OM. While the client can be used when the client is
lucky and connected to the OM.
While I can accept this behavior, it seems to be confusing. One Ozone user
may think that hadoop2 compatible Ozone client can be used together with OM HA,
but in fact it's unsafe beacuse it can be failed after any of the leader
election.
I would consider to always throw an exception when HA is configured (but I
can be convinced from the opposite).
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
