GlenGeng commented on a change in pull request #1844:
URL: https://github.com/apache/ozone/pull/1844#discussion_r567603062
##########
File path:
hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto
##########
@@ -196,7 +196,9 @@ message ContainerCommandRequestProto {
optional PutSmallFileRequestProto putSmallFile = 20;
optional GetSmallFileRequestProto getSmallFile = 21;
optional GetCommittedBlockLengthRequestProto getCommittedBlockLength = 22;
+
optional string encodedToken = 23;
+ optional uint32 version = 24;
Review comment:
better keep the style consistent. Up to you.
##########
File path: hadoop-hdds/interface-server/src/main/proto/ScmServerProtocol.proto
##########
@@ -48,6 +48,7 @@ message SCMBlockLocationRequest {
optional string traceID = 2;
optional UserInfo userInfo = 3;
+ optional uint32 version = 4;
Review comment:
Will clientVersion be more straightforward than version in these protos,
in case we might add other version into proto message ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
