elek commented on pull request #1419: URL: https://github.com/apache/ozone/pull/1419#issuecomment-771943596
Thanks for the answer @arp7. I am afraid we have a different definition of *cosmetic change*. When a file with 349 lines (`wc hadoop-hdds/docs/content/design/storage-class.md`) is changed with 515 lines of patch (`curl https://github.com/apache/ozone/commit/f52cd5a4f617bb5984959ea928951eec12ae9ab9.patch | wc`) I don't think it's a cosmetic change. (even if the patch file contains the context of the changes). You may miss, but the *cosmetic change* replaced the **definition** of the storage class compared to the previous version: ``` -Let's define the *storage-class* as set of used container **types and transitions** between them during the life cycle of the containers. +Storage class is a selection of replication mechanism and definition of parameters. ``` > You have failed to address fundamental questions about what storage classes mean with a container-based storage model like what Ozone uses. Thanks for the feedback. With all the respect I don't think that this sentence is completely true. At least not in a way, what I could use it to learn it from. From my point of this was answer in the document and I also tried to answer the questions in the comment (or at least get quetions). But it seems that I am definitely failed to continue an effective discussion with you, wether it's my fault or not. I am closing this PR now, and trying to answer the open questions (how to support multiple replication method) in the EC doc. Hope we can have a good discussion there. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
