vivekratnavel commented on a change in pull request #1874:
URL: https://github.com/apache/ozone/pull/1874#discussion_r572453487
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/metadata/SCMDBDefinition.java
##########
@@ -73,13 +75,30 @@
public static final DBColumnFamilyDefinition<ContainerID, ContainerInfo>
CONTAINERS =
- new DBColumnFamilyDefinition<ContainerID, ContainerInfo>(
+ new DBColumnFamilyDefinition<>(
"containers",
ContainerID.class,
new ContainerIDCodec(),
ContainerInfo.class,
new ContainerInfoCodec());
+ public static final DBColumnFamilyDefinition<Long, CRLInfo> CRL_INFO =
+ new DBColumnFamilyDefinition<>(
+ "crlInfo",
+ Long.class,
+ new LongCodec(),
+ CRLInfo.class,
+ new CRLInfoCodec());
+
+ public static final DBColumnFamilyDefinition<String, Long>
+ CRL_SEQUENCE_ID =
Review comment:
Good suggestion @xiaoyuyao. But, having this sequence id stored in
RocksDB gives us the ability to batch transactions when revoke certificates
operation is executed. If we use the version file to keep track of this id, we
will lose this ability and might cause conflicts with the CRL sequence id.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
