lokeshj1703 commented on a change in pull request #1885:
URL: https://github.com/apache/ozone/pull/1885#discussion_r576161627
##########
File path:
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestContainerDeletionChoosingPolicy.java
##########
@@ -109,27 +111,37 @@ public void testRandomChoosingPolicy() throws IOException
{
}
blockDeletingService = getBlockDeletingService();
+ int blockLimitPerInterval = 5;
ContainerDeletionChoosingPolicy deletionPolicy =
new RandomContainerDeletionChoosingPolicy();
- List<ContainerData> result0 =
- blockDeletingService.chooseContainerForBlockDeletion(5,
deletionPolicy);
- Assert.assertEquals(5, result0.size());
+ List<ContainerBlockInfo> result0 = blockDeletingService
+ .chooseContainerForBlockDeletion(blockLimitPerInterval,
deletionPolicy);
+
+ if (result0.size() > 0) {
Review comment:
We should remove the if conditions in this test related to result0,
result1 and result2 size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
