adoroszlai commented on code in PR #100:
URL: https://github.com/apache/ozone-site/pull/100#discussion_r1914326958


##########
docs/08-developer-guide/01-build/01-maven.md:
##########
@@ -0,0 +1,103 @@
+---
+sidebar_label: Maven
+---
+
+
+# Building Ozone With Maven
+
+import Tabs from '@theme/Tabs';
+import TabItem from '@theme/TabItem';
+
+This guide explains how to build Apache Ozone from source using Maven and 
prepare it for deployment.
+
+## Prerequisites
+
+Before you begin, ensure you have the following installed on your build 
machine:
+
+- Java 1.8 or higher
+- Apache Maven 3.6.3 or higher
+- Git (if building from source repository)
+
+## Obtain the Source Code
+
+You can build Apache Ozone either by cloning the source code from Git or by 
downloading the official source tarball.
+
+Choose one of the following methods to get the source code:
+
+<Tabs>
+  <TabItem value="Git" label="Git" default>
+    Use this option to build any release, tag or commit of Ozone.
+    ```bash
+    git clone https://github.com/apache/ozone.git
+    cd ozone
+    ```
+  </TabItem>
+  <TabItem value="Tarball" label="Tarball">
+    Use this option if you only want a released version of Ozone. Source code 
for Ozone releases can be obtained from the [download page](/download).
+    ```bash
+    tar xzf ozone-<version>-src.tar.gz
+    cd ozone-<version>-src
+    ```
+  </TabItem>
+</Tabs>
+
+## Build the Project
+
+Apache Ozone uses [Maven](https://maven.apache.org/) as its build system. The 
build process compiles the source code, runs tests, and creates deployable 
artifacts. The project supports various build configurations to accommodate 
different development and deployment needs.
+
+### Build Options
+
+The build system offers several options to customize the build process 
according to your requirements
+
+#### Basic Build with Tests
+
+```bash
+mvn clean package
+```
+
+This command will:
+
+- Clean previous build artifacts
+- Compile the source code
+- Package the compiled code into JAR files
+- Create a distribution in `hadoop-ozone/dist/target/ozone-<version>`
+- Run [unit](/docs/developer-guide/test/unit-tests) and 
[integration](/docs/developer-guide/test/integration-tests) tests during the 
build
+
+:::note
+
+This command does not run acceptance tests. Refer to the [acceptance 
tests](/docs/developer-guide/test/acceptance-tests) page for test execution 
instructions.
+
+:::
+
+#### Common Maven Build Options
+
+| Command                       | Description                                  
                                                                                
                                           |
+|-------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| `-DskipTests=true`            | Skip all tests                               
                                                                                
                                           |
+| `-Pdist`                      | This creates a tarball in 
`hadoop-ozone/dist/target` that contains all necessary files for deployment     
                                                              |
+| `-DskipRecon`                 | Skip building the Javascript frontend for 
Recon                                                                           
                                              |
+| `-Pdist`                      | Enable the distribution profile to create 
deployment tarballs                                                             
                                              |
+| `-T 4`                        | Use 4 threads for parallel building (adjust 
number based on your CPU)                                                       
                                            |
+| `-T 2C`                       | Use 2 threads per core for parallel building 
(adjust number based on your CPU)                                               
                                           |

Review Comment:
   nit: I guess the benefit of using the per-core value is that it adapts to 
your CPU.
   
   ```suggestion
   | `-T 4`                        | Use 4 threads for parallel building 
(adjust number based on your CPU)                                               
                                                    |
   | `-T 2C`                       | Use 2 threads per core for parallel 
building                                                                        
                  |
   ```



##########
docs/08-developer-guide/01-build/01-maven.md:
##########
@@ -0,0 +1,103 @@
+---
+sidebar_label: Maven
+---
+
+
+# Building Ozone With Maven
+
+import Tabs from '@theme/Tabs';
+import TabItem from '@theme/TabItem';
+
+This guide explains how to build Apache Ozone from source using Maven and 
prepare it for deployment.
+
+## Prerequisites
+
+Before you begin, ensure you have the following installed on your build 
machine:
+
+- Java 1.8 or higher
+- Apache Maven 3.6.3 or higher
+- Git (if building from source repository)
+
+## Obtain the Source Code
+
+You can build Apache Ozone either by cloning the source code from Git or by 
downloading the official source tarball.
+
+Choose one of the following methods to get the source code:
+
+<Tabs>
+  <TabItem value="Git" label="Git" default>
+    Use this option to build any release, tag or commit of Ozone.
+    ```bash
+    git clone https://github.com/apache/ozone.git
+    cd ozone
+    ```
+  </TabItem>
+  <TabItem value="Tarball" label="Tarball">
+    Use this option if you only want a released version of Ozone. Source code 
for Ozone releases can be obtained from the [download page](/download).
+    ```bash
+    tar xzf ozone-<version>-src.tar.gz
+    cd ozone-<version>-src
+    ```
+  </TabItem>
+</Tabs>
+
+## Build the Project
+
+Apache Ozone uses [Maven](https://maven.apache.org/) as its build system. The 
build process compiles the source code, runs tests, and creates deployable 
artifacts. The project supports various build configurations to accommodate 
different development and deployment needs.
+
+### Build Options
+
+The build system offers several options to customize the build process 
according to your requirements
+
+#### Basic Build with Tests
+
+```bash
+mvn clean package
+```
+
+This command will:
+
+- Clean previous build artifacts
+- Compile the source code
+- Package the compiled code into JAR files
+- Create a distribution in `hadoop-ozone/dist/target/ozone-<version>`
+- Run [unit](/docs/developer-guide/test/unit-tests) and 
[integration](/docs/developer-guide/test/integration-tests) tests during the 
build
+
+:::note
+
+This command does not run acceptance tests. Refer to the [acceptance 
tests](/docs/developer-guide/test/acceptance-tests) page for test execution 
instructions.
+
+:::
+
+#### Common Maven Build Options
+
+| Command                       | Description                                  
                                                                                
                                           |
+|-------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| `-DskipTests=true`            | Skip all tests                               
                                                                                
                                           |
+| `-Pdist`                      | This creates a tarball in 
`hadoop-ozone/dist/target` that contains all necessary files for deployment     
                                                              |
+| `-DskipRecon`                 | Skip building the Javascript frontend for 
Recon                                                                           
                                              |
+| `-Pdist`                      | Enable the distribution profile to create 
deployment tarballs                                                             
                                              |

Review Comment:
   `-Pdist` is duplicated
   
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to