errose28 commented on code in PR #8030:
URL: https://github.com/apache/ozone/pull/8030#discussion_r1991799247


##########
hadoop-ozone/dist/src/shell/ozone/ozone:
##########
@@ -103,6 +104,10 @@ function ozonecmd_case
         exit -1
       fi
     ;;
+    completion)
+      OZONE_CLASSNAME=org.apache.hadoop.ozone.utils.AutoCompletion;
+      OZONE_RUN_ARTIFACT_NAME="ozone-tools"
+    ;;

Review Comment:
   `daemonlog` looks like a wrapper to set the log level on a service over 
HTTP, similar to doing this through the web UI, which looks useful. I can't 
figure out the use case for `dtutil` though.
   
   What would the distinction be between `util` and `debug`? I think 
`checknative`, `classpath`, and `envvars` make sense under `debug`, but I'm ok 
with `ozone completion` being a top level command since its result applies to 
the whole CLI.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to