bshashikant commented on a change in pull request #2116:
URL: https://github.com/apache/ozone/pull/2116#discussion_r609467785
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/protocol/StorageContainerLocationProtocolServerSideTranslatorPB.java
##########
@@ -329,6 +331,9 @@ public ScmContainerLocationResponse processRequest(
"Unknown command type: " + request.getCmdType());
}
} catch (IOException e) {
+ if (SCMHAUtils.isRetriableWithNoFailoverException(e)) {
Review comment:
> Given client side has already done the check, the server side can just
return a `ServiceException` containing the real exception.
The Service exception is not thrown for all exceptions back from server.
Only for certain exceptions, it throws service exception. Only
StorageContainerLocation server seems to be sending back service exception back
to client for each failure. I have remove the check in
StorageContainerLocationServer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
