jojochuang commented on code in PR #7957: URL: https://github.com/apache/ozone/pull/7957#discussion_r2004107890
########## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/om/CompactOMDB.java: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.repair.om; + +import java.io.IOException; +import org.apache.hadoop.hdds.cli.HddsVersionProvider; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.ozone.om.helpers.OMNodeDetails; +import org.apache.hadoop.ozone.om.protocolPB.OMAdminProtocolClientSideImpl; +import org.apache.hadoop.ozone.repair.RepairTool; +import org.apache.hadoop.security.UserGroupInformation; +import picocli.CommandLine; + +/** + * Tool to perform compaction on a column family of an om.db. + */ [email protected]( + name = "compact", + description = "CLI to compact a column family in the om.db. " + + "The compaction happens asynchronously.", Review Comment: ```suggestion "The compaction happens asynchronously. Requires admin privilege.", ``` ########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OMAdminProtocolServerSideImpl.java: ########## @@ -101,4 +103,22 @@ public DecommissionOMResponse decommission(RpcController controller, .setSuccess(true) .build(); } + + @Override + public CompactResponse compactDB(RpcController controller, CompactRequest compactRequest) + throws ServiceException { + try { + // check if table exists. IOException is thrown if table is not found. Review Comment: We should only allow admin to compact it. ```suggestion if (!ozoneManager.isAdmin(getRemoteUser())) { throw new OMException("Only administrators are authorized to perform compaction.", PERMISSION_DENIED); } // check if table exists. IOException is thrown if table is not found. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
