[
https://issues.apache.org/jira/browse/HDDS-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937586#comment-17937586
]
Attila Doroszlai edited comment on HDDS-12662 at 3/22/25 11:55 AM:
-------------------------------------------------------------------
I think the test is wrong. -{{ozone freon dfsg}} should be expected to succeed
even before finalization, because- {{OzoneOutputStream}} falls back to
{{flush()}} if HSync is disabled. Edit: looks like HSync disabled is just a
client-side thing, so the test is correct, but
{{ozone.client.hbase.enhancements.allowed}} is not set.
{code:title=https://github.com/apache/ozone/blob/828b2d116bd1d4f17e6623cc291afdd0e4432d05/hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/OzoneOutputStream.java#L114-L123}
// Disable the feature flag restores the prior behavior.
if (!enableHsync) {
outputStream.flush();
return;
}
if (syncable != null) {
if (outputStream != syncable) {
outputStream.flush();
}
syncable.hsync();
{code}
was (Author: adoroszlai):
I think the test is wrong. {{ozone freon dfsg}} should be expected to succeed
even before finalization, because {{OzoneOutputStream}} falls back to
{{flush()}} if HSync is disabled.
{code:title=https://github.com/apache/ozone/blob/828b2d116bd1d4f17e6623cc291afdd0e4432d05/hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/OzoneOutputStream.java#L114-L123}
// Disable the feature flag restores the prior behavior.
if (!enableHsync) {
outputStream.flush();
return;
}
if (syncable != null) {
if (outputStream != syncable) {
outputStream.flush();
}
syncable.hsync();
{code}
> Rename upgrade callback directory 1.5.0 to 2.0.0
> ------------------------------------------------
>
> Key: HDDS-12662
> URL: https://issues.apache.org/jira/browse/HDDS-12662
> Project: Apache Ozone
> Issue Type: Bug
> Reporter: Wei-Chiu Chuang
> Assignee: Chia-Chuan Yu
> Priority: Blocker
> Labels: pull-request-available
>
> Not a blocker issue, but we should rename
> [https://github.com/apache/ozone/tree/master/hadoop-ozone/dist/src/main/compose/upgrade/upgrades/non-rolling-upgrade/callbacks/1.5.0]
> to 2.0.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
