adoroszlai opened a new pull request, #8181:
URL: https://github.com/apache/ozone/pull/8181
## What changes were proposed in this pull request?
- Implement `StorageLocationReport#toString()`, and use it for log messages
that previously included current usage (capacity/available/used). Example:
```diff
-[main] INFO volume.HddsVolume: Creating HddsVolume: /data/hdds/hdds of
storage type: DISK, capacity=499546271036, used=4096, available=64331067392
+[main] INFO volume.HddsVolume: Creating HddsVolume: {
dir=/data/hdds/hdds type=DISK capacity=499546271036 used=0
available=64334258176 minFree=104857600 committed=0 }
```
- Replace `AvailableSpace` (in `AvalailableSpaceFilter`) with
`StorageLocationReport`.
```diff
- No volumes have enough space for a new container. Most available
space: 250 bytes; required space: 500, volumes:
{/tmp/junit-3722094462097746233disk1/hdds=free: 100, committed: 0,
/tmp/junit-3722094462097746233disk2/hdds=free: 200, committed: 0,
/tmp/junit-3722094462097746233disk3/hdds=free: 300, committed: 50}
+ No volumes have enough space for a new container. Most available
space: 250 bytes; required space: 500, volumes: [{
dir=/tmp/junit-1140086590420520691disk1/hdds type=DISK
id=DS-d7e636a5-b210-4955-b39a-eb80fb5fe88d capacity=500 used=400 available=100
minFree=0 committed=0 }, { dir=/tmp/junit-1140086590420520691disk2/hdds
type=DISK id=DS-478347d0-30dc-4cce-8b86-ccb0d3c238b5 capacity=500 used=300
available=200 minFree=0 committed=0 }, {
dir=/tmp/junit-1140086590420520691disk3/hdds type=DISK
id=DS-2433384c-c9e5-4499-b70d-7261cbb08287 capacity=500 used=200 available=300
minFree=0 committed=50 }]
```
- Include volume report in replication/import failure log.
- Log if container close is triggered due to volume full.
- Add `getUsableSpace()` in `StorageLocationReport` for convenience.
- Set storage location in the report to `storageDir`, not `volumeRoot` (to
differentiate between `HddsVolume`, `DbVolume` etc. in the same root).
- Remove unused method getMetadataFromProtobuf from StorageLocationReport.
https://issues.apache.org/jira/browse/HDDS-12721
## How was this patch tested?
https://github.com/adoroszlai/ozone/actions/runs/14124678056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
