peterxcli commented on code in PR #8157:
URL: https://github.com/apache/ozone/pull/8157#discussion_r2019674462
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -988,6 +989,9 @@ private void instantiateServices(boolean withNewSnapshot)
throws IOException {
fsSnapshotEnabled = configuration.getBoolean(
OMConfigKeys.OZONE_FILESYSTEM_SNAPSHOT_ENABLED_KEY,
OMConfigKeys.OZONE_FILESYSTEM_SNAPSHOT_ENABLED_DEFAULT);
+ fsSnapshotMaxLimit = configuration.getInt(
Review Comment:
> 2\. Please remove this config from
[OmMetadataManagerImpl](https://github.com/apache/ozone/blob/86d2027e328cd66c3319b355f3438842440ffa70/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java#L592)
and
[DBStoreBuilder](https://github.com/apache/ozone/blob/eb96ff489209ad9dab10a3cded277ae5ccd7cb4a/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBStoreBuilder.java#L101).
I was planning to clean them in
https://issues.apache.org/jira/browse/HDDS-12690.
But if you feel ok, I can make the changes together in this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
