jojochuang commented on code in PR #7495:
URL: https://github.com/apache/ozone/pull/7495#discussion_r2023653981
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java:
##########
@@ -175,13 +178,41 @@ public void setIpAddress(String ip) {
this.ipAddress = StringWithByteString.valueOf(ip);
}
+ /**
+ * Resolves and validates the IP address of the datanode based on its
hostname.
+ * If the resolved IP address differs from the current IP address,
+ * it updates the IP address to the newly resolved value.
+ */
+ public void validateDatanodeIpAddress() {
+ final String oldIP = getIpAddress();
+ final String hostname = getHostName();
+ if (StringUtils.isBlank(hostname)) {
+ LOG.warn("Could not resolve IP address of datanode '{}'", this);
+ return;
+ }
+
+ try {
+ final String newIP = InetAddress.getByName(hostname).getHostAddress();
+ if (StringUtils.isBlank(newIP)) {
+ throw new UnknownHostException("New IP address is invalid: " + newIP);
+ }
+
+ if (!newIP.equals(oldIP)) {
+ LOG.info("Updating IP address of datanode {} to {}", this, newIP);
Review Comment:
this.toString() format is "UUID(hostname/old_ip_address)" so this log would
become
Updating IP address of datanode UUID(hostname/old_ip_address) to
new_ip_address
It may look confusing initially but okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
