swamirishi commented on code in PR #8053: URL: https://github.com/apache/ozone/pull/8053#discussion_r2026390445
########## hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestMultiSnapshotLocks.java: ########## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.om.snapshot; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.anyCollection; +import static org.mockito.ArgumentMatchers.anyList; +import static org.mockito.ArgumentMatchers.eq; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.times; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; + +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.UUID; +import org.apache.hadoop.ozone.om.exceptions.OMException; +import org.apache.hadoop.ozone.om.lock.IOzoneManagerLock; +import org.apache.hadoop.ozone.om.lock.OMLockDetails; +import org.apache.hadoop.ozone.om.lock.OzoneManagerLock; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.extension.ExtendWith; +import org.mockito.ArgumentMatchers; +import org.mockito.Mock; +import org.mockito.junit.jupiter.MockitoExtension; + +/** + * Class to test class MultiLocks. + */ +@ExtendWith(MockitoExtension.class) +public class TestMultiSnapshotLocks { + @Mock + private IOzoneManagerLock mockLock; + + @Mock + private OzoneManagerLock.Resource mockResource; + + private MultiSnapshotLocks multiSnapshotLocks; + private UUID obj1 = UUID.randomUUID(); + private UUID obj2 = UUID.randomUUID(); + + @BeforeEach + void setUp() { + // Initialize MultiLocks with mock dependencies + multiSnapshotLocks = new MultiSnapshotLocks(mockLock, mockResource, true); + } + + @Test + void testAcquireLockSuccess() throws Exception { + List<UUID> objects = Arrays.asList(obj1, obj2); + OMLockDetails mockLockDetails = mock(OMLockDetails.class); + when(mockLockDetails.isLockAcquired()).thenReturn(true); + + // Simulate successful lock acquisition for each object + when(mockLock.acquireWriteLocks(eq(mockResource), anyList())).thenReturn(mockLockDetails); + + OMLockDetails result = multiSnapshotLocks.acquireLock(objects); + + assertEquals(mockLockDetails, result); + verify(mockLock, times(1)).acquireWriteLocks(ArgumentMatchers.eq(mockResource), any()); + } + + @Test + void testAcquireLockFailureReleasesAll() throws Exception { + + List<UUID> objects = Arrays.asList(obj1, obj2); + OMLockDetails failedLockDetails = mock(OMLockDetails.class); + when(failedLockDetails.isLockAcquired()).thenReturn(false); + + // Simulate failure during lock acquisition + when(mockLock.acquireWriteLocks(eq(mockResource), anyCollection())).thenReturn(failedLockDetails); + + OMLockDetails result = multiSnapshotLocks.acquireLock(objects); + + assertEquals(failedLockDetails, result); + assertTrue(multiSnapshotLocks.getObjectLocks().isEmpty()); + } + + @Test + void testReleaseLock() throws Exception { + List<UUID> objects = Arrays.asList(obj1, obj2); + OMLockDetails mockLockDetails = mock(OMLockDetails.class); + when(mockLockDetails.isLockAcquired()).thenReturn(true); + + // Acquire locks first + when(mockLock.acquireWriteLocks(eq(mockResource), anyCollection())).thenReturn(mockLockDetails); + multiSnapshotLocks.acquireLock(objects); + assertFalse(multiSnapshotLocks.getObjectLocks().isEmpty()); + + // Now release locks + multiSnapshotLocks.releaseLock(); + + // Verify that locks are released in order + verify(mockLock).releaseWriteLocks(eq(mockResource), any()); + assertTrue(multiSnapshotLocks.getObjectLocks().isEmpty()); + } + + @Test + void testAcquireLockWhenAlreadyAcquiredThrowsException() throws Exception { Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
