SaketaChalamchala commented on code in PR #8157:
URL: https://github.com/apache/ozone/pull/8157#discussion_r2032149324


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java:
##########
@@ -104,6 +104,8 @@ public OMSnapshotCreateRequest(OMRequest omRequest) {
   @RequireSnapshotFeatureState(true)
   public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
     final OMRequest omRequest = super.preExecute(ozoneManager);
+    // verify snapshot limit
+    ozoneManager.getOmSnapshotManager().snapshotLimitCheck();

Review Comment:
   I agree with @hemantk-12. We need not reject a snapshot create because of 
inFlight Snapshot create requests. inFlight snapshot creates may not always 
result in a snapshot being created and added to the chain. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org

Reply via email to