sadanand48 commented on code in PR #8124:
URL: https://github.com/apache/ozone/pull/8124#discussion_r2043763369
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java:
##########
@@ -1436,19 +1436,26 @@ private CancelSnapshotDiffResponse cancelSnapshotDiff(
}
private ListSnapshotDiffJobResponse listSnapshotDiffJobs(
- ListSnapshotDiffJobRequest listSnapshotDiffJobRequest)
- throws IOException {
- List<SnapshotDiffJob> snapshotDiffJobs =
- impl.listSnapshotDiffJobs(
- listSnapshotDiffJobRequest.getVolumeName(),
- listSnapshotDiffJobRequest.getBucketName(),
- listSnapshotDiffJobRequest.getJobStatus(),
- listSnapshotDiffJobRequest.getListAll());
- ListSnapshotDiffJobResponse.Builder builder =
- ListSnapshotDiffJobResponse.newBuilder();
- for (SnapshotDiffJob diffJob : snapshotDiffJobs) {
+ ListSnapshotDiffJobRequest listSnapshotDiffJobRequest
+ ) throws IOException {
+ org.apache.hadoop.ozone.snapshot.ListSnapshotDiffJobResponse response =
impl.listSnapshotDiffJobs(
+ listSnapshotDiffJobRequest.getVolumeName(),
+ listSnapshotDiffJobRequest.getBucketName(),
+ listSnapshotDiffJobRequest.getJobStatus(),
+ listSnapshotDiffJobRequest.getListAll(),
+ listSnapshotDiffJobRequest.getPrevSnapshotDiffJob(),
+ listSnapshotDiffJobRequest.getMaxListResult());
Review Comment:
To make it backward compatible, we need to check:
```java
int maxListResult =
listSnapshotDiffJobRequest.hasMaxListResult()?listSnapshotDiffJobRequest.getMaxListResult():Integer.MAX_VALUE;
org.apache.hadoop.ozone.snapshot.ListSnapshotDiffJobResponse response =
impl.listSnapshotDiffJobs(
listSnapshotDiffJobRequest.getVolumeName(),
listSnapshotDiffJobRequest.getBucketName(),
listSnapshotDiffJobRequest.getJobStatus(),
listSnapshotDiffJobRequest.getListAll(),
listSnapshotDiffJobRequest.getPrevSnapshotDiffJob(),
maxListResult);
```
or -1 denoting unlimited listing (need to handle this case in code). This
way old clients will retain old behaviour of no pagination else it will not
list any element.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
