adoroszlai commented on code in PR #7968:
URL: https://github.com/apache/ozone/pull/7968#discussion_r2049137118
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/CopyContainerCompression.java:
##########
@@ -51,18 +51,16 @@ public OutputStream wrap(OutputStream output) {
SNAPPY(CompressorStreamFactory.SNAPPY_FRAMED),
ZSTD(CompressorStreamFactory.ZSTANDARD);
+ private static final Logger LOG =
LoggerFactory.getLogger(CopyContainerCompression.class);
+
private final String compressorFactoryName;
+ private static final CopyContainerCompression DEFAULT_COMPRESSION =
CopyContainerCompression.NO_COMPRESSION;
Review Comment:
I suggest ordering member variables as:
- `static final`
- `static`
- instance variables
I don't know if there is a PMD rule to enforce that, and even if there is,
definitely no need to enable it as part of this change. Just make these moves
to reduce future change where possible, like in this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
