ChenSammi commented on code in PR #8127:
URL: https://github.com/apache/ozone/pull/8127#discussion_r2052221550
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/policy/DefaultContainerChoosingPolicy.java:
##########
@@ -35,13 +35,17 @@ public class DefaultContainerChoosingPolicy implements
ContainerChoosingPolicy {
@Override
public ContainerData chooseContainer(OzoneContainer ozoneContainer,
- HddsVolume hddsVolume, Set<Long> inProgressContainerIDs) {
+ HddsVolume hddsVolume, Set<Long> inProgressContainerIDs,
+ Set<Long> replicationContainerIDs) {
Iterator<Container<?>> itr = ozoneContainer.getController()
.getContainers(hddsVolume);
while (itr.hasNext()) {
ContainerData containerData = itr.next().getContainerData();
- if (!inProgressContainerIDs.contains(
- containerData.getContainerID()) && containerData.isClosed()) {
+ long containerID = containerData.getContainerID();
+
+ if (!replicationContainerIDs.contains(containerID) &&
+ !inProgressContainerIDs.contains(containerID) &&
+ containerData.isClosed() && !containerData.isEmpty()) {
Review Comment:
please check isClosed and isEmpty() first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
