jojochuang commented on PR #8141: URL: https://github.com/apache/ozone/pull/8141#issuecomment-2822669862
The PR looks really good to me. I wonder if compacting to the bottom most is required, because these are column families in the snapshots, so supposedly no change. Compacting to the bottom most for the first time a snapshot get evicted out of cache may make sense, but subsequent compactions for the same snapshot wouldn't make a difference. Or maybe we should compact column families not tracked in the DAG when a snapshot is created? Do it in the background asynchronously so snapshot create request returns immediately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
