umamaheswararao commented on a change in pull request #2069:
URL: https://github.com/apache/ozone/pull/2069#discussion_r613593892
##########
File path:
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestContainerDataYaml.java
##########
@@ -179,44 +180,7 @@ public void testIncorrectContainerFile() throws
IOException{
GenericTestUtils.assertExceptionContains("No enum constant", ex);
}
}
-
-
Review comment:
I was thinking the newer client will always do checksums for available
fields in file, but not from java enum fields. Older client will do as is.
Also think about the option ignore the additional field when replIndex is 0,
which is default. So, for non-existent we can assume that as 0 in newer clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
