jojochuang commented on code in PR #8016:
URL: https://github.com/apache/ozone/pull/8016#discussion_r2074114903
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -1386,14 +1205,9 @@ public boolean shouldRun() {
return !suspended.get();
}
- @VisibleForTesting
- public boolean debugEnabled(Integer level) {
- return DEBUG_LEVEL.contains(level);
- }
-
@VisibleForTesting
public ConcurrentHashMap<String, CompactionNode> getCompactionNodeMap() {
- return compactionNodeMap;
+ return (ConcurrentHashMap<String, CompactionNode>)
compactionDag.getCompactionMap();
Review Comment:
IMO this method should be rewritten as ConcurrentMap.
In general, returning more abstract type is preferred, as it avoid a lot of
unnecessary code change later, just like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
