ChenSammi commented on code in PR #8276:
URL: https://github.com/apache/ozone/pull/8276#discussion_r2076858811
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -2311,6 +2311,77 @@ message DeleteObjectTaggingRequest {
message DeleteObjectTaggingResponse {
}
+/**
+S3 lifecycles (filter, expiration, rule and configuration).
+ */
+message LifecycleFilterTag {
+ required string key = 1;
+ required string value = 2;
+}
+
+message LifecycleRuleAndOperator {
+ optional string prefix = 1;
+ repeated LifecycleFilterTag tags = 2;
+}
+
+// TODO: proto 2.5 does not support oneof fields, once we start using protoc
3.x, consider to refactor these message using "oneof"
+/*
+message LifecycleFilter {
+ oneof Filter {
+ string prefix = 1;
+ LifecycleFilterTag tag = 2;
+ LifecycleRuleAndOperator andOperator = 3;
+ }
+}
+
+message LifecycleExpiration {
+ oneof Condition {
+ uint32 days = 1;
+ string date = 2;
+ }
+}
+
+message LifecycleRule {
+ //...
+ oneof Condition {
+ optional string prefix = 4;
+ optional LifecycleFilter filter = 5;
Review Comment:
@ashishkumar50 , I think this is OK, there are fields before oneof is not
displayed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
