peterxcli commented on code in PR #8360:
URL: https://github.com/apache/ozone/pull/8360#discussion_r2077494420
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java:
##########
@@ -434,8 +435,12 @@ ContainerCommandResponseProto handleCreateContainer(
LOG.debug("Container already exists. container Id {}", containerID);
}
} catch (StorageContainerException ex) {
+ exceptionThrown = true;
return ContainerUtils.logAndReturnError(LOG, ex, request);
} finally {
+ if (exceptionThrown) {
Review Comment:
> 2\. we might first check whether space is committed before release, for
newContainer.create can throw out exception from
volumeChoosingPolicy.chooseVolume too.
`releaseCommitSpace` itself already checked that:
https://github.com/apache/ozone/blob/57f254d13c61714d34d9ec1776e9589075369361/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerData.java#L359-L361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
