peterxcli commented on PR #8360: URL: https://github.com/apache/ozone/pull/8360#issuecomment-2864950853
> i'm curious why capacity-based is several times slower than round-robin. But regardless, 12 thousand CreateContainer per second is more than enough. It seems that these two lines are the cause: [https://github.com/apache/ozone/blob/f52069b7aa757d39e4819bae7d06b12955660576/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/CapacityVolumeChoosingPolicy.java#L58-L60](https://github.com/apache/ozone/blob/f52069b7aa757d39e4819bae7d06b12955660576/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/CapacityVolumeChoosingPolicy.java#L58-L60) [https://github.com/apache/ozone/blob/f52069b7aa757d39e4819bae7d06b12955660576/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/CapacityVolumeChoosingPolicy.java#L82-L83](https://github.com/apache/ozone/blob/f52069b7aa757d39e4819bae7d06b12955660576/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/CapacityVolumeChoosingPolicy.java#L82-L83) Round-robin doesn't iterate or use randomness — in an ideal case, each call should just run `AvailableSpaceFilter` test and return `volumeSet[i++]`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
