ChenSammi commented on code in PR #8388:
URL: https://github.com/apache/ozone/pull/8388#discussion_r2083734772
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -296,7 +297,7 @@ public class DatanodeConfiguration extends
ReconfigurableConfig {
" Either of min.free.space or min.free.space.percent should be
configured, when both are set then" +
" min.free.space will be used."
)
- private float minFreeSpaceRatio = MIN_FREE_SPACE_UNSET;
+ private float minFreeSpaceRatio =
HDDS_DATANODE_VOLUME_MIN_FREE_SPACE_PERCENT_DEFAULT;
Review Comment:
We shall update update minFreeSpace default value too.
Also please update the description for
"hdds.datanode.volume.min.free.space.percent" and
"hdds.datanode.volume.min.free.space" that both both properties will be
considered in final free space calculation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
